Repository navigation
feat(tracking): send gift_package on purchase - #17
Merged
Merged
Conversation
Android v2.37.0 -> v2.38.0, iOS 3.31.0 -> 3.33.0.
DEV-T-691. `isGiftPackage` on `tracking.purchase` (and the deprecated `trackPurchase`) reaches the wire as `gift_package` only when true, the way `tax_free` does. Android builds the payload in the bridge, iOS hands the flag to the native request.
The Android bridge hand-rolled the purchase JSON — wire keys, validation and the reserved-`custom` list — and posted it through the deprecated `SDK.sendAsync`, because published artifacts once had no public `trackPurchase`. They do now, so the plugin builds a `PurchaseTrackingRequest` and calls `sdk.tracking.purchase` the way every other event already goes through the namespace, and 290 lines of duplicated serialization are gone. Two gaps close with it: the stored attribution from `setSource` now reaches purchases, and a popup carried by the purchase response is handled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v2.38.0, iOSREES46 3.33.0.isGiftPackageontracking.purchase(and the deprecatedtrackPurchase), sent asgift_packageonly when true.PurchaseTrackingRequestand callssdk.tracking.purchase, dropping ~290 lines of duplicated serialization and validation. With it, the storedsetSourceattribution and popups carried by the purchase response now reach purchases.